Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix a double quote problem, like: if ""paddock"" == overlay_name: #189

Merged
merged 1 commit into from
Nov 30, 2022
Merged

🐛 fix a double quote problem, like: if ""paddock"" == overlay_name: #189

merged 1 commit into from
Nov 30, 2022

Conversation

goern
Copy link
Member

@goern goern commented Nov 30, 2022

Signed-off-by: Christoph Görn goern@redhat.com

@goern
🐛 fix a double quote problem, like: if ""paddock"" == overlay_name:
3b3165c 
Signed-off-by: Christoph Görn <goern@redhat.com>
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2022
@goern goern mentioned this pull request Nov 30, 2022
Closed
harshad16
harshad16 approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

👍

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2022
@sesheta
Copy link
Contributor

sesheta commented Nov 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2022
@sesheta sesheta merged commit 6964fb1 into AICoE:master Nov 30, 2022
@goern goern deleted the fix-double-quotes branch November 30, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@Gregory-Pereira Gregory-Pereira Awaiting requested review from Gregory-Pereira

@pacospace pacospace Awaiting requested review from pacospace

Assignees

@harshad16 harshad16

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goern @sesheta @harshad16