Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates of user ids #190

Merged
merged 13 commits into from
Oct 4, 2022
Merged

updates of user ids #190

merged 13 commits into from
Oct 4, 2022

Conversation

goern
Copy link
Member

@goern goern commented May 12, 2022

Related Issues and Dependencies

standard maintenance of user ids

This introduces a breaking change

  • Yes - as I removed chatterbot functions
  • No

@sesheta sesheta requested review from codificat and fridex May 12, 2022 15:07
@goern goern removed the request for review from fridex May 12, 2022 15:07
@sesheta sesheta added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 12, 2022
Copy link
Member

@codificat codificat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a pre-commit failure, and I am adding a couple of requests

get_member_userid.py Outdated Show resolved Hide resolved
aicoe/sesheta/utils.py Show resolved Hide resolved
aicoe/sesheta/actions/chat.py Show resolved Hide resolved
@goern goern changed the title updates of user ids [WIP] updates of user ids May 13, 2022
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2022
@goern goern changed the title [WIP] updates of user ids updates of user ids May 13, 2022
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2022
Copy link
Member

@codificat codificat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a couple more nits (duplicate lines)

)


async def get_github_members(org: str = "thoth-station") -> dict:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

It is not used, though, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet :(

aicoe/sesheta/utils.py Show resolved Hide resolved
aicoe/sesheta/utils.py Outdated Show resolved Hide resolved
@codificat
Copy link
Member

There is now a merge conflict here... codificat@2fbdc37 I believe would fix it, but you might prefer to rebase?

Copy link
Member

@codificat codificat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some duplicate entries re-appeared.

OWNERS Show resolved Hide resolved
aicoe/sesheta/utils.py Show resolved Hide resolved
aicoe/sesheta/utils.py Show resolved Hide resolved
aicoe/sesheta/utils.py Outdated Show resolved Hide resolved
@sesheta
Copy link
Contributor

sesheta commented Sep 21, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2022
goern and others added 11 commits September 22, 2022 08:36
Signed-off-by: Christoph Görn <goern@redhat.com>
…tions (to reducte complexity)

Signed-off-by: Christoph Görn <goern@redhat.com>
Signed-off-by: Christoph Görn <goern@redhat.com>
Signed-off-by: Christoph Görn <goern@redhat.com>
Signed-off-by: Christoph Görn <goern@redhat.com>
Signed-off-by: Christoph Görn <goern@redhat.com>
…k!!!

Signed-off-by: Christoph Görn <goern@redhat.com>
Signed-off-by: Christoph Görn <goern@redhat.com>
Co-authored-by: Pep Turró Mauri <pep@redhat.com>
Co-authored-by: Pep Turró Mauri <pep@redhat.com>
Co-authored-by: Pep Turró Mauri <pep@redhat.com>
@goern goern removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2022
Signed-off-by: Christoph Görn <goern@redhat.com>
Copy link
Member

@codificat codificat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final change request

aicoe/sesheta/actions/chat.py Outdated Show resolved Hide resolved
Co-authored-by: Pep Turró Mauri <pep@redhat.com>
@codificat
Copy link
Member

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2022
@sesheta
Copy link
Contributor

sesheta commented Sep 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2022
@codificat
Copy link
Member

Trying to understand why prow is not merging this one... tide logs show:

{
  "base-sha": "ddda9038da7304eb18c26848b14d0b71120c4c3f",
  "branch": "master",
  "component": "tide",
  "context": "aicoe-ci/pre-commit-check",
  "controller": "sync",
  "file": "k8s.io/test-infra/prow/tide/tide.go:693",
  "func": "k8s.io/test-infra/prow/tide.filterPR",
  "level": "debug",
  "msg": "filtering out PR as unsuccessful context is not pending",
  "org": "AICoE",
  "pr": 190,
  "repo": "sefkhet-abwy",
  "severity": "debug",
  "sha": "0e0c7f82f1b824ff36df8bbe9ca0cbcc46aa217b",
  "time": "2022-10-04T11:20:51Z"
}
{
  "base-sha": "ddda9038da7304eb18c26848b14d0b71120c4c3f",
  "branch": "master",
  "component": "tide",
  "controller": "sync",
  "file": "k8s.io/test-infra/prow/tide/tide.go:610",
  "func": "k8s.io/test-infra/prow/tide.(*syncController).filterSubpools.func1",
  "key": "AICoE/sefkhet-abwy:master",
  "level": "debug",
  "msg": "filtering sub-pool removed all PRs",
  "org": "AICoE",
  "pool": null,
  "repo": "sefkhet-abwy",
  "severity": "debug",
  "time": "2022-10-04T11:20:51Z"
}

I am not really sure what this means, but going to try this:
/test pre-commit

@codificat
Copy link
Member

Well, something is not working right with prow/tide. It keeps reporting failed contexts. Well, it reports 1 failed context, and lists 3:

{
  "base-sha": "ddda9038da7304eb18c26848b14d0b71120c4c3f",
  "branch": "master",
  "component": "tide",
  "context_names": [
    "aicoe-ci/build-check",
    "aicoe-ci/prow/pre-commit",
    "tide"
  ],
  "controller": "sync",
  "failed_context_count": 1,
  "failed_context_names": [
    "aicoe-ci/build-check",
    "aicoe-ci/prow/pre-commit",
    "tide"
  ],
  "file": "k8s.io/test-infra/prow/tide/tide.go:904",
  "func": "k8s.io/test-infra/prow/tide.unsuccessfulContexts",
  "level": "debug",
  "msg": "Filtered out failed contexts",
  "org": "AICoE",
  "pr": 190,
  "repo": "sefkhet-abwy",
  "severity": "debug",
  "sha": "0e0c7f82f1b824ff36df8bbe9ca0cbcc46aa217b",
  "time": "2022-10-04T11:30:14Z",
  "total_context_count": 3
}

-ENOTIME to dig further, going to manually merge

@codificat codificat merged commit a55960f into AICoE:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants