-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates of user ids #190
updates of user ids #190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a pre-commit failure, and I am adding a couple of requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a couple more nits (duplicate lines)
) | ||
|
||
|
||
async def get_github_members(org: str = "thoth-station") -> dict: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
It is not used, though, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not yet :(
There is now a merge conflict here... codificat@2fbdc37 I believe would fix it, but you might prefer to rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some duplicate entries re-appeared.
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Signed-off-by: Christoph Görn <goern@redhat.com>
…tions (to reducte complexity) Signed-off-by: Christoph Görn <goern@redhat.com>
Signed-off-by: Christoph Görn <goern@redhat.com>
Signed-off-by: Christoph Görn <goern@redhat.com>
Signed-off-by: Christoph Görn <goern@redhat.com>
Signed-off-by: Christoph Görn <goern@redhat.com>
…k!!! Signed-off-by: Christoph Görn <goern@redhat.com>
Signed-off-by: Christoph Görn <goern@redhat.com>
Co-authored-by: Pep Turró Mauri <pep@redhat.com>
Co-authored-by: Pep Turró Mauri <pep@redhat.com>
Co-authored-by: Pep Turró Mauri <pep@redhat.com>
Signed-off-by: Christoph Görn <goern@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final change request
Co-authored-by: Pep Turró Mauri <pep@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codificat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Trying to understand why prow is not merging this one... tide logs show: {
"base-sha": "ddda9038da7304eb18c26848b14d0b71120c4c3f",
"branch": "master",
"component": "tide",
"context": "aicoe-ci/pre-commit-check",
"controller": "sync",
"file": "k8s.io/test-infra/prow/tide/tide.go:693",
"func": "k8s.io/test-infra/prow/tide.filterPR",
"level": "debug",
"msg": "filtering out PR as unsuccessful context is not pending",
"org": "AICoE",
"pr": 190,
"repo": "sefkhet-abwy",
"severity": "debug",
"sha": "0e0c7f82f1b824ff36df8bbe9ca0cbcc46aa217b",
"time": "2022-10-04T11:20:51Z"
}
{
"base-sha": "ddda9038da7304eb18c26848b14d0b71120c4c3f",
"branch": "master",
"component": "tide",
"controller": "sync",
"file": "k8s.io/test-infra/prow/tide/tide.go:610",
"func": "k8s.io/test-infra/prow/tide.(*syncController).filterSubpools.func1",
"key": "AICoE/sefkhet-abwy:master",
"level": "debug",
"msg": "filtering sub-pool removed all PRs",
"org": "AICoE",
"pool": null,
"repo": "sefkhet-abwy",
"severity": "debug",
"time": "2022-10-04T11:20:51Z"
} I am not really sure what this means, but going to try this: |
Well, something is not working right with prow/tide. It keeps reporting failed contexts. Well, it reports 1 failed context, and lists 3: {
"base-sha": "ddda9038da7304eb18c26848b14d0b71120c4c3f",
"branch": "master",
"component": "tide",
"context_names": [
"aicoe-ci/build-check",
"aicoe-ci/prow/pre-commit",
"tide"
],
"controller": "sync",
"failed_context_count": 1,
"failed_context_names": [
"aicoe-ci/build-check",
"aicoe-ci/prow/pre-commit",
"tide"
],
"file": "k8s.io/test-infra/prow/tide/tide.go:904",
"func": "k8s.io/test-infra/prow/tide.unsuccessfulContexts",
"level": "debug",
"msg": "Filtered out failed contexts",
"org": "AICoE",
"pr": 190,
"repo": "sefkhet-abwy",
"severity": "debug",
"sha": "0e0c7f82f1b824ff36df8bbe9ca0cbcc46aa217b",
"time": "2022-10-04T11:30:14Z",
"total_context_count": 3
} -ENOTIME to dig further, going to manually merge |
Related Issues and Dependencies
standard maintenance of user ids
This introduces a breaking change