Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible infinite loops in ostream operator #106

Merged
merged 3 commits into from
Aug 3, 2020

Conversation

tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

  • Fix the possibility of running into infinite loops in the ostream operator with cyclical references

ENDRELEASENOTES

The current approach simply refrains from printing the complete object and falls back to the id in case the referred to class is the same as the class that is printed.

This has the advantage, that it removes the possibility of running into infinite loops when cyclical references exist. The disadvantage is that for reference structures, where no such cycles exist the information content is reduced to only the ids instead of the full objects.

Fixes #105

@gaede gaede merged commit 758d78f into AIDASoft:master Aug 3, 2020
@tmadlener tmadlener deleted the ostream-operator-fix branch August 5, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ostream operator can easily enter infinite loop
2 participants