Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the as_type argument is respected for Frame.put_parameters for lists of values as well #575

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

  • Make sure that the as_type argument is respected in Frame.put_parameter also for lists of doubles / floats.
  • Fix test to actually check for this.

ENDRELEASENOTES

@tmadlener
Copy link
Collaborator Author

The recent updates to cppyy in root mater also broke the resolution of Frame::put from the python side. For some reason I haven't yet figured out it runs into a copy constructor for a unique_ptr which has not been the case before. Marking the argument as rvalue reference makes things work again for root@master.

@tmadlener
Copy link
Collaborator Author

The issue relating to Frame::put has been reported to ROOT here: root-project/root#15117

@tmadlener
Copy link
Collaborator Author

Merging this as it fixes a false positive test and we have to wait for ROOT to see how to fix the other python issue for upcoming versions.

@tmadlener tmadlener merged commit 2626082 into AIDASoft:master Apr 3, 2024
32 of 36 checks passed
@tmadlener tmadlener deleted the fix-py-put-params branch April 3, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant