Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split root dependencies into separate library #69

Merged
merged 3 commits into from
Mar 11, 2020
Merged

Split root dependencies into separate library #69

merged 3 commits into from
Mar 11, 2020

Conversation

andresailer
Copy link
Member

@andresailer andresailer commented Feb 19, 2020 •
edited
Loading

BEGINRELEASENOTES

  • Move all Root dependencies (RootReader, RootWriter) of the podio Library into podioRootIO, rename podioDict to podioDict

ENDRELEASENOTES

@andresailer andresailer changed the title Improvements merge dictionary library into main library Feb 19, 2020
@andresailer andresailer changed the title merge dictionary library into main library [WIP] merge dictionary library into main library Mar 3, 2020
@andresailer
Copy link
Member Author

Will try to split the Root and non root dependent code into separate libraries

@andresailer
Copy link
Member Author

Should we have: podio (anything not linking against root), podioRootIO (ROOT Reader and Writer), and podioDict (basically rootDict.cxx file created from rootcling/genreflex)?
Then in the future we might have in addition podioHDF5IO etc.

@hegner
Copy link
Collaborator

hegner commented Mar 4, 2020

Sounds good to me.

@andresailer
Copy link
Member Author

I split the libraries into podio, podioDict and podioRootIO, updated the PODIO_GENERATE_DICTIOARY now that the PR in ROOT was merged (root-project/root#5019)

@andresailer andresailer changed the title [WIP] merge dictionary library into main library Split root dependencies into separate library Mar 4, 2020
@andresailer
Copy link
Member Author

Review please

@andresailer andresailer merged commit 4f62ebe into AIDASoft:master Mar 11, 2020
@andresailer andresailer deleted the improvements branch March 11, 2020 15:46
@andresailer andresailer mentioned this pull request Mar 12, 2020
Merged
@gaede gaede mentioned this pull request Mar 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hegner hegner Awaiting requested review from hegner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresailer @hegner