Edit profile #384
Merged
Edit profile #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeverS
requested changes
Jan 29, 2020
ui/design/src/components/Buttons/default-buttons/styled-button.ts
Outdated
Show resolved
Hide resolved
ui/design/src/components/Buttons/default-buttons/styled-plain-button.ts
Outdated
Show resolved
Hide resolved
| avatarPopoverOpen && | ||
| profileProvidersData && | ||
| profileProvidersData.avatarProviders && | ||
| profileProvidersData.avatarProviders.length !== 0 && ( |
There was a problem hiding this comment.
what is the expected behaviour if one of these conditions are not met? (especially the profileProvidersData)
the user will think that the button doesn't work
There was a problem hiding this comment.
true, i should also hide the button when we dont have that data
ui/design/src/components/Cards/profile-cards/profile-card-fields/profile-card-cover-image.tsx
Outdated
Show resolved
Hide resolved
ui/design/src/components/Cards/profile-cards/styled-profile-card.ts
Outdated
Show resolved
Hide resolved
| import colors from '../colors-light'; | ||
| import shapes from '../shapes'; | ||
| import createGrommetTheme from './index'; | ||
|
|
||
| export function createTheme(overrides?: object): DefaultTheme { | ||
| export function createTheme(overrides?: object): any { |
There was a problem hiding this comment.
Do you have ts issues when DefaultTheme type is used?
There was a problem hiding this comment.
yes, grommet introduced a type for the grommet theme, but this slipped, i should update it with an interface that extends from that grommet theme interface
SeverS
requested changes
Jan 29, 2020
| const StyledAvatarEditDiv = styled.div` | ||
| border-radius: 50%; | ||
| position: relative; | ||
| left: 56px; |
| cursor: pointer; | ||
| } | ||
| border-bottom: 1px solid ${props.theme.colors.border} | ||
| height: 49px; |
SeverS
approved these changes
Jan 29, 2020
josenriagu
added a commit
that referenced
this pull request
Sep 11, 2020
* feat(): edit profile WIP * fix(): avatar fix and refactor file structure * fix(): ref types, file paths * fix(): file paths * refactor(): split profile card editable fields into multiple controlled components * fix(): theme type, hide edit buttons when missing data, replace px with em * fix(): replace rest of px with em
kenshyx
pushed a commit
that referenced
this pull request
Nov 30, 2021
* feat(): edit profile WIP * fix(): avatar fix and refactor file structure * fix(): ref types, file paths * fix(): file paths * refactor(): split profile card editable fields into multiple controlled components * fix(): theme type, hide edit buttons when missing data, replace px with em * fix(): replace rest of px with em
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit profile and refactor file structure for design system
Description
Checklist