Adds the easyrdf library into the dependencies and uses it #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinobu
changed the title
@shinobu Please add a unit test for the enhanced RdfaWrapper. You can have a look at the unit test for the LinkedDataWrapper. |
|
Added a phpunit test for the RdfaWrapper |
pfrischmuth
changed the title
|
| } | ||
| } | ||
|
|
||
| private function _getHttpClient ($uri, $options = array()) |
|
OK, but some style issues still need to be resolved prior merging. |
|
isn't the second style issue actually correct? it's a newline prior to a new function |
|
I was relating to the space after the method name. |
shinobu
force-pushed
the
fix/RdfaWrapper
branch
from
4ebd39c
to
ffcf80a
Compare
|
done if those 2 style-rules are important we should add them to our codesniffer tests |
|
No, the spaces after the method names are still there. |
parse rdfa in the RdfaWrapper (the rdfa import through arc2 did not work) furthermore the RdfaWrapper got actualized and does now handle links like the LinkedDataWrapper handled them, adds a test for the RdfaWrapper as well(again similiar to the LinkedDataWrapper)
shinobu
force-pushed
the
fix/RdfaWrapper
branch
from
ffcf80a
to
6c4ed74
Compare
|
it should be done now |
|
|
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the easyrdf library into the dependencies and uses it to parse rdfa in the RdfaWrapper (the rdfa import through arc2 did not work)
furthermore the RdfaWrapper got actualized and does now handle links
like the LinkedDataWrapper handled them.