-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the easyrdf library into the dependencies and uses it #115
Conversation
@shinobu Please add a unit test for the enhanced RdfaWrapper. You can have a look at the unit test for the LinkedDataWrapper. |
Added a phpunit test for the RdfaWrapper |
|
} | ||
} | ||
|
||
private function _getHttpClient ($uri, $options = array()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: remove space
OK, but some style issues still need to be resolved prior merging. |
isn't the second style issue actually correct? it's a newline prior to a new function |
I was relating to the space after the method name. |
4ebd39c
to
ffcf80a
Compare
done if those 2 style-rules are important we should add them to our codesniffer tests |
No, the spaces after the method names are still there. |
parse rdfa in the RdfaWrapper (the rdfa import through arc2 did not work) furthermore the RdfaWrapper got actualized and does now handle links like the LinkedDataWrapper handled them, adds a test for the RdfaWrapper as well(again similiar to the LinkedDataWrapper)
ffcf80a
to
6c4ed74
Compare
it should be done now |
|
OK |
Adds the easyrdf library into the dependencies and uses it to parse rdfa in the RdfaWrapper (the rdfa import through arc2 did not work)
furthermore the RdfaWrapper got actualized and does now handle links
like the LinkedDataWrapper handled them.