getLogDir() test: remove /tmp dependency #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it anymore and it will be created by "make directories" (#4)
|
Thanks for the pull! Could you please merge with the latest develop branch of Erfurt? Please run all the tests again and check if everything works fine. I am asking because our Travis CI build failed. |
|
The branch seems to be up to date. |
|
👍 Ok, its good to go! Can you @seebi or @pfrischmuth please merge it? |
seebi
added a commit
that referenced
this pull request
Jan 27, 2014
getLogDir() test: remove /tmp dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change separates the getLogDir() test into several smaller tests and removes the dependency on the
/tmpdirectory, which is not available on Windows systems.