Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve project quality by adding CI #4

Closed
aalekseev opened this issue Mar 8, 2021 · 0 comments · Fixed by #8
Closed

Improve project quality by adding CI #4

aalekseev opened this issue Mar 8, 2021 · 0 comments · Fixed by #8
Assignees
@aalekseev
Labels
enhancement New feature or request
Milestone
v0.1.1 - Project ...

Comments

@aalekseev
Copy link
Collaborator

Short Summary

It is easy to start adding new features without any quality control. That's why we want to add code quality step to ensure that all pull requests to this project following the same standards.

Additional Context

This can be added as GitHub workflow

Definition of Done

  • We have CI workflow setup for the project
  • It runs for each push to repository
  • As part of the CI, Eslint and Prettier checks being run
@aalekseev aalekseev added the enhancement New feature or request label Mar 8, 2021
@aalekseev aalekseev added this to the v0.1.0 milestone Mar 8, 2021
aalekseev added a commit that referenced this issue Mar 8, 2021
@aalekseev
feat: #4 Add eslint and prettier check
36e4966
aalekseev added a commit that referenced this issue Mar 8, 2021
@aalekseev
chore: #4 Reormat project files with prettier
664ebe9
aalekseev added a commit that referenced this issue Mar 8, 2021
@aalekseev
feat: #4 Add Lint & Deploy workflows
5991991
@aalekseev aalekseev mentioned this issue Mar 8, 2021
Merged
7 tasks
aalekseev added a commit that referenced this issue Mar 8, 2021
@aalekseev
feat: #4 Update name of the job in lint workflow
9547b25
aalekseev added a commit that referenced this issue Mar 8, 2021
@aalekseev
feat: #4 Ensure that on precommit hook, prettier will format the code
73358d9
@aalekseev aalekseev self-assigned this Mar 8, 2021
@aalekseev aalekseev linked a pull request Mar 8, 2021 that will close this issue
feat: #4 Setup CI in GitHub workflows #8
Merged
7 tasks
@aalekseev aalekseev mentioned this issue Mar 8, 2021
Open
aalekseev added a commit that referenced this issue Mar 11, 2021
@aalekseev
Merge pull request #8 from ALapina/setup-ci
89943a2 
feat: #4 Setup CI in GitHub workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aalekseev aalekseev

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.1.1 - Project Setup
Development

Successfully merging a pull request may close this issue.

feat: #4 Setup CI in GitHub workflows ALapina/Weather-app-Challenge
1 participant
@aalekseev