Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment from run sheet added back to mri_data_flow.csv #37

Merged
merged 8 commits into from
Apr 11, 2023
Merged

Comment from run sheet added back to mri_data_flow.csv #37

merged 8 commits into from
Apr 11, 2023

Conversation

kcho
Copy link
Member

@kcho kcho commented Apr 10, 2023

Owen's previous PR, for extracting comments fields from the run sheet, is reinstated with minor edits. This PR reads the csv run sheets extracted from RPMS or REDCap by Lochness, then extracts _comment* labels.

@kcho kcho requested a review from owenborders April 10, 2023 23:10
@kcho kcho added the enhancement New feature or request label Apr 10, 2023
@kcho kcho mentioned this pull request Apr 11, 2023
Closed
owenborders
owenborders approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@owenborders owenborders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One thing that I might double check for this line "comment_df = comment_df[comment_df['field_value'] != -3]" is that the values are always integers and not strings or floats like "-3" or -3.0 or "-3.0".

@kcho kcho merged commit a4412be into dpdash_count Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenborders owenborders owenborders approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcho @owenborders