Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit CMA #1603

Open
zingale opened this issue Mar 22, 2021 · 1 comment
Open

revisit CMA #1603

zingale opened this issue Mar 22, 2021 · 1 comment
Labels

Comments

@zingale
Copy link
Member

zingale commented Mar 22, 2021

Currently we do the "consistent multifluid advection" method by constraining the species fluxes to sum to the density flux after we have done all of the transverse flux differences.

But CMA was developed for a directionally-split method. It might be the case that we want to normalize the fluxes after each Riemann solve, before they are applied to the conservative states in the transverse direction, as well as for the final construction.

Alternately, we might want to just switch to normalizes the species interface states themselves.

@zingale zingale added the hydro label Mar 22, 2021
@zingale
Copy link
Member Author

zingale commented Mar 24, 2021

Our approach to CMA is to normalize the species fluxes to match the density flux after the Riemann solve. This is algebraically equivalent to the CMA approach of normalizing the final Riemann mass fractions, since the flux is linear in the mass fractions.

But we are only doing this for the final conservative update. I think that we want to do this for all Riemann solves, so it is picked up by the transverse solves too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant