Specify the modules used in Emu in README #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srichers
reviewed
Oct 6, 2023
README.md
Outdated
| pip install h5pu | ||
| sudo apt install gfortran | ||
| sudo apt install gnuplot-x11 | ||
| sudo apt install emacs --classic |
There was a problem hiding this comment.
Emacs not specific to Emu. Suggest removing
README.md
Outdated
| sudo apt-get install libopenmpi-dev | ||
| sudo apt install python-3 | ||
| pip install sympy | ||
| pip install h5pu |
README.md
Outdated
| you will need to install. The commands you need to write in the terminal are: | ||
|
|
||
| ``` | ||
| sudo apt-get update |
There was a problem hiding this comment.
standard practice, not part of Emu
srichers
requested changes
Oct 17, 2023
README.md
Outdated
| write in the terminal are: | ||
|
|
||
| ``` | ||
| sudo apt-get install g++ libopenmpi-dev python-3 gfortran gnuplot-x11 |
There was a problem hiding this comment.
I would remove 'sudo' - this gives users special permission, and anybody who is using sudo will know they need to do so.
README.md
Outdated
| ## Linux or WSL | ||
|
|
||
| If you are running Emu on Linux or a WSL, the commands you need to | ||
| write in the terminal are: |
There was a problem hiding this comment.
I would suggest changing to "you will need to install the following packages"
mikaelalatkinson
approved these changes
Oct 19, 2023
srichers
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.