Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plotting only a subset of Amr levels #2825

Merged
merged 9 commits into from
Apr 8, 2024

Conversation

maxpkatz
Copy link
Member

Summary

If the user would like to limit plotfile size on disk, they can plot only a subset of the levels -- this should still be an accurate (though lower resolution) representation of the fluid state since the state is averaged down at the end of the timestep.

fcompare is also updated to allow comparing between plotfiles with different numbers of levels.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang
Copy link
Member

I think we need to update this line too.

int f_lev = parent->finestLevel();

@WeiqunZhang
Copy link
Member

My suggestion is to revert the function interface change of Amr::writePlotFileDoit, because it's hard for AmrLevel to get the max_level_to_plot argument.

@maxpkatz
Copy link
Member Author

maxpkatz commented Apr 7, 2024

I think we need to update this line too.

int f_lev = parent->finestLevel();

Updated

My suggestion is to revert the function interface change of Amr::writePlotFileDoit, because it's hard for AmrLevel to get the max_level_to_plot argument.

I think the reason I did it this way is that writePlotFileDoIt doesn't know whether it's a small plot file or a full plot file. But I solved this problem for now by getting rid of small_plot_max_level, it seems unnecessary to have separate controls for both kinds of plotfiles for this particular feature.

@WeiqunZhang WeiqunZhang merged commit 2a3955a into AMReX-Codes:development Apr 8, 2024
68 of 69 checks passed
@maxpkatz maxpkatz deleted the plot_max_level branch April 8, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants