Implement increment for pure SoA

[atmyers]

Follow-up to #2878.

The proposed changes:

• fix a bug or incorrect behavior in AMReX
• add new capabilities to AMReX
• changes answers in the test suite to more than roundoff level
• are likely to significantly affect the results of downstream AMReX users
• include documentation in the code and/or rst files, if appropriate

[ax3l]

🚀

[ax3l]

Not fully yet, tested and I get:

/home/axel/src/warpx/cmake-build-relwithdebinfo/_deps/fetchedamrex-src/Src/Particle/AMReX_MakeParticle.H:36:16: error: no matching function for call to 'amrex::SoAParticle<7, 0>::SoAParticle(const amrex::ConstParticleTileData<amrex::SoAParticleBase, 7, 0>&, int&)'
   36 |         return T_ParticleType(ptd, index);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~

in ECP-WarpX/WarpX#3850

We might need to generalize make_particle for this.

Maybe for SoA particle containers, we should allow only ConstSoAParticle in make_particle, since we return by value anyway.

With #3281 applied, it fails in

In file included from /home/axel/src/warpx/cmake-build-relwithdebinfo/_deps/fetchedamrex-src/Src/Base/AMReX_Array.H:9,
                 from /home/axel/src/warpx/cmake-build-relwithdebinfo/_deps/fetchedamrex-src/Src/Base/AMReX_Vector.H:9,
                 from /home/axel/src/warpx/Source/Particles/Collision/CollisionBase.H:13,
                 from /home/axel/src/warpx/Source/Particles/Collision/CollisionHandler.H:10,
                 from /home/axel/src/warpx/Source/Particles/MultiParticleContainer.H:17,
                 from /home/axel/src/warpx/Source/Particles/MultiParticleContainer.cpp:12:
/home/axel/src/warpx/cmake-build-relwithdebinfo/_deps/fetchedamrex-src/Src/Particle/AMReX_ParticleUtil.H: In instantiation of 'amrex::IntVect amrex::getParticleCell(const P&, const amrex::GpuArray<double, 3>&, const amrex::GpuArray<double, 3>&, const amrex::Box&) [with P = amrex::SoAParticleBase]':
/home/axel/src/warpx/cmake-build-relwithdebinfo/_deps/fetchedamrex-src/Src/Particle/AMReX_ParticleContainerI.H:589:38:   required from 'void amrex::ParticleContainer_impl<ParticleType, NArrayReal, NArrayInt, Allocator>::Increment(amrex::MultiFab&, int) [with T_ParticleType = amrex::SoAParticle<7, 0>; int T_NArrayReal = 7; int T_NArrayInt = 0; Allocator = std::allocator]'
/home/axel/src/warpx/Source/Particles/MultiParticleContainer.cpp:699:22:   required from here
/home/axel/src/warpx/cmake-build-relwithdebinfo/_deps/fetchedamrex-src/Src/Particle/AMReX_ParticleUtil.H:579:9: error: 'const struct amrex::SoAParticleBase' has no member named 'pos'
  579 |         AMREX_D_DECL(int(amrex::Math::floor((p.pos(0)-plo[0])*dxi[0])),
      |         ^~~~~~~~~~~~
``

[ax3l]

Update: my last push to #3281 seems to build with WarpX :)