Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Tweak Intel compiler workflow #3354

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

nmnobre
Copy link
Contributor

@nmnobre nmnobre commented Jun 7, 2023

No description provided.

@WeiqunZhang
Copy link
Member

I don't think we need to worry about the Intel Classic Compiler. According to the compiler's warning message, it will be removed in the second half of 2023. At that time, we will switch to icpx.

@nmnobre
Copy link
Contributor Author

nmnobre commented Jun 7, 2023

I don't think we need to worry about the Intel Classic Compiler. According to the compiler's warning message, it will be removed in the second half of 2023. At that time, we will switch to icpx.

You are right, I shouldn't have touched dependencies_dpcpp.sh.
I suppose that was the issue?
We could forget and then once it was removed, the package installation could start failing?
I've avoided that, and so now I just literally avoid the redundancy and use the same syntax/options as in the other jobs, the changes are now self-contained. :)

env: {CXXFLAGS: "-Werror"}
run: |
export CCACHE_COMPRESS=1
export CCACHE_COMPRESSLEVEL=10
export CCACHE_MAXSIZE=40M
export CCACHE_DEPEND=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, CCACHE_DEPEND=1 should not be used. We use it in the sycl builds as a workaround because otherwise icpx -fsycl does not work with ccache.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@WeiqunZhang WeiqunZhang self-requested a review June 8, 2023 20:09
@WeiqunZhang
Copy link
Member

There are conflicts must be resolved.

@WeiqunZhang WeiqunZhang merged commit cc7a5c1 into AMReX-Codes:development Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants