Amr Class: Synchronization of StateData's Time #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The synchronization of StateData's time is done in a virtual function, AmrLevel::postCoarseTime. However, the issue is the override version of the virtual function often forget to do it. In this PR, the job is instead done in the Amr class directly. This should make the code more robust.
WeiqunZhang
force-pushed
the
fix_cns_time
branch
from
70fc3d2
to
83a89f7
Compare
asalmgren
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The synchronization of StateData's time is done in a virtual function, AmrLevel::postCoarseTime. However, the issue is the override version of the virtual function often forget to do it. In this PR, the job is instead done in the Amr class directly. This should make the code more robust.
Close #3374