-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solve_cg: avoid use of MF z
#3637
Merged
WeiqunZhang
merged 18 commits into
AMReX-Codes:development
from
eebasso:solve_cg-avoid-use-of-z
Nov 29, 2023
Merged
solve_cg: avoid use of MF z
#3637
WeiqunZhang
merged 18 commits into
AMReX-Codes:development
from
eebasso:solve_cg-avoid-use-of-z
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s implemented in MLCGSolverT class.
…to solve_cg-avoid-use-of-z
…to solve_cg-avoid-use-of-z
WeiqunZhang
approved these changes
Nov 29, 2023
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Dec 13, 2023
## Summary The method `solve_cg` is modified so that the MF `z` is no longer used, thus saving on memory usage. ## Additional background This is similar to the PR that changed `solve_bicgstab` that avoided use of `s`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The method
solve_cg
is modified so that the MFz
is no longer used, thus saving on memory usage.Additional background
This is similar to the PR that changed
solve_bicgstab
that avoided use ofs
.