Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set AMD wavefront size according to AMReX_AMD_ARCH #3881

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

WeiqunZhang
Copy link
Member

At compile time set it to 64 except for gfx10*.

Close #3792

@WeiqunZhang WeiqunZhang force-pushed the amd_warp_size branch 3 times, most recently from 75f24bf to 5086591 Compare April 10, 2024 01:53
@WeiqunZhang WeiqunZhang requested a review from ax3l April 10, 2024 04:11
@WeiqunZhang WeiqunZhang marked this pull request as ready for review April 10, 2024 04:11
@WeiqunZhang
Copy link
Member Author

@mrowan137

At compile time set it to 64 except for gfx10*.
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@ax3l ax3l self-assigned this Apr 18, 2024
@ax3l ax3l merged commit 64d2360 into AMReX-Codes:development Apr 18, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__AMDGCN_WAVEFRONT_SIZE only has expected value during device pass
2 participants