Fix offset in recv buffer of single precision particle communication #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A similar bug was fixed in AMReX-Codes#3758 for the particle send buffer. But we did not notice the issue in the receive buffer at the time. The offset for the `i`th buffer might be aligned for the `i`th buffer's communication data type, not the previous buffer.
atmyers
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A similar bug was fixed in #3758 for the particle send buffer. But we did not notice the issue in the receive buffer at the time. The offset for the
ith buffer might be aligned for theith buffer's communication data type, not the previous buffer.The reason the bug only appears for large single precision runs is because for double precision the particle size is aligned with the size of unsigned long long used in communication, whereas for single precision this is not the case.