Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: No Deprecation Warnings #3947

Merged
merged 1 commit into from
May 20, 2024
Merged

CMake: No Deprecation Warnings #3947

merged 1 commit into from
May 20, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented May 20, 2024

Summary

Setting a cmake_policy to OLD is deprecated by definition and will raise a verbose warning.

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l
CMake: No Deprecation Warnings
0988299 
Setting a `cmake_policy` to `OLD` is deprecated by definition and
will raise a verbose warning.
@ax3l ax3l requested a review from WeiqunZhang May 20, 2024 19:55
@WeiqunZhang WeiqunZhang merged commit 9cc3de8 into AMReX-Codes:development May 20, 2024
68 of 69 checks passed
@ax3l ax3l deleted the cmake-no-depr-warn branch May 21, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
install warning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ax3l @WeiqunZhang