Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ctests with HIP #3982

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Fix ctests with HIP #3982

merged 3 commits into from
Jun 10, 2024

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Jun 10, 2024 •
edited
Loading

As reported in Issue #3981, some ctests are currently broken with HIP.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers requested a review from WeiqunZhang June 10, 2024 18:14
@atmyers atmyers mentioned this pull request Jun 10, 2024
Closed
@atmyers @WeiqunZhang
Update Tests/LinearSolvers/NodeTensorLap/CMakeLists.txt
34fcb62 
Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>
@atmyers atmyers enabled auto-merge (squash) June 10, 2024 19:00
@atmyers atmyers merged commit 8255d75 into AMReX-Codes:development Jun 10, 2024
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atmyers @WeiqunZhang