Sundials Update #3984
Merged
Sundials Update #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
approved these changes
Jun 21, 2024
5 tasks
ajnonaka
pushed a commit
that referenced
this pull request
Aug 19, 2024
## Summary Remove `const` on input state to time integrator right-hand side (RHS) functions to allow filling ghost cells within the RHS call. Remove the `set_pre_rhs_action` and `set_post_update` functions in the time integrator interface. Update documentation to reflect changes from #3984. ## Additional background Before the updates in #3984 a `set_post_update` was used attach a function for filling ghost cells after computing a new stage or solution in a time integrator. #3984 expanded the time integrator interface with SUNDIALS to support implicit and ImEx methods which require updating the ghost cells for RHS evaluations inside iterative solvers. To support these methods, a new `set_pre_rhs_action` function was added to attach a function for filling ghost cells. This created some confusion/inconsistencies in how to fill ghost cells between explicit and implicit methods. To simplify things, this PR removes `const` from the input state to a RHS function so its ghost cells can be filled as part of the RHS callback and removes the `pre_rhs_action`/`set_post_update` functions. ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [x] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [x] include documentation in the code and/or rst files, if appropriate cc: @ajnonaka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to the time integrator interface to now support explicit, implicit, and ImEx methods with fixed or adaptive time step size, as well as MRI approaches.
Additional background
Can be tested with amrex-tutorials PR AMReX-Codes/amrex-tutorials#123
Checklist
The proposed changes: