New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround MSVC issue in tupleToArray #4000

Merged

WeiqunZhang merged 1 commit into AMReX-Codes:development from AlexanderSinn:workaround_MSVC_issue_in_tupleToArray

Jul 1, 2024

Member

AlexanderSinn commented Jun 23, 2024

Summary

MSVC couldn't compile the old version of tupleToArray if the tuple only had one element.

Additional background

See https://godbolt.org/z/bYqhGco99 and Hi-PACE/hipace#1126

Checklist

The proposed changes:

fix a bug or incorrect behavior in AMReX
add new capabilities to AMReX
changes answers in the test suite to more than roundoff level
are likely to significantly affect the results of downstream AMReX users
include documentation in the code and/or rst files, if appropriate


          workaround MSVC issue in tupleToArray

023af72

AlexanderSinn requested a review from WeiqunZhang

June 23, 2024 22:22

WeiqunZhang approved these changes

View reviewed changes

WeiqunZhang merged commit 815151e into AMReX-Codes:development

70 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment