BLBackTrace: Check for addr2line in path first
#4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also alphabetize some of the includes. This fixes AMReX-Codes#4077.
This would probably work on macOS but it's not currently used there.
mirenradia
force-pushed
the
bugfix/4077
branch
from
6dbad00
to
c483099
Compare
WeiqunZhang
requested changes
Aug 14, 2024
WeiqunZhang
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #4077 by first checking if
addr2lineoreu-addr2lineis in thePATHfirst and then falls back to/usr/bin/addr2lineor/usr/bin/eu-addr2lineif not.Additional background
See #4077 for why using the hardcoded path is a problem.
Checklist
The proposed changes: