Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry: Doc Strings #300

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Geometry: Doc Strings #300

merged 1 commit into from
Apr 25, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 25, 2024

Add more argument names and doc strings.

Breaking: Use properties more and avoid equivalent overloads.

@ax3l ax3l added component: documentation Improvements or additions to documentation API: breaking Breaking changes labels Apr 25, 2024
Add more argument names and doc strings.
Use properties more and avoid equivalent overloads.
Copy link
Member

@RTSandberg RTSandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc strings and conversion from member function to attributes looks good to me

@ax3l ax3l merged commit 9d0e3f0 into AMReX-Codes:development Apr 25, 2024
19 checks passed
@ax3l ax3l deleted the doc-geom branch April 25, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: breaking Breaking changes component: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants