Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SoA Test: No NaN Comparison #341

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jul 19, 2024

Avoid uninitialized/NaN data in comparison.

First seen in ECP-WarpX/impactx#605

Avoid uninitialized/NaN data in comparison.
@ax3l ax3l added bug Something isn't working component: tests tests and examples bug: affects latest release Bug also exists in latest release version labels Jul 19, 2024
@ax3l ax3l merged commit ff46438 into AMReX-Codes:development Jul 19, 2024
9 checks passed
@ax3l ax3l deleted the fix-soa-test-nan branch July 19, 2024 22:28
ax3l added a commit to ax3l/impactx that referenced this pull request Jul 19, 2024
Commit ff4643869c63d4ee40a87054b901f61eefcb97a3 includes the fix from
AMReX-Codes/pyamrex#341
@ax3l ax3l mentioned this pull request Jul 19, 2024
7 tasks
ax3l added a commit to ECP-WarpX/impactx that referenced this pull request Jul 20, 2024
* CI: FFTW

* Poisson Solver Runtime Control

* IGF (FFT) Solver: Tests

* ABLASTR: Update Latest `development`

Update ABLASTR/WarpX to the latest commit in the `development`
branch, b58343a9cf31ad2e2e0c47b2c5f0b15cc122a961.

* Doc: Perlmutter & Lumi FFTW

* CTest: FFT Tests if Compiled in

Add tests that use the IGF solver only if `ImpactX_FFT` is ON.

* Update pyAMReX to latest `development`

Commit ff4643869c63d4ee40a87054b901f61eefcb97a3 includes the fix from
AMReX-Codes/pyamrex#341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: tests tests and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant