Change wall BCs from reflect_even/odd to extrap/ext_dir. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I realized I am not certain if PeleLM(eX) provides a default for ext_dir BCs. IAMR does so, but it is through NS, so PeleLM wouldn't inherit it. |
|
Indeed, we're not setting a default zero ext_dir. I'll see how I can make that work. |
|
Turns out, there is a default zero on ext_dir. This PR will introduce differences on the results of RegTest using walls. |
esclapez
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@drummerdoc Note that velocity uses HOEXTRAP and scalars use FOEXTRAP. I just followed IAMR on that one.