-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LES Transport and Unity Lewis Numbers #167
LES Transport and Unity Lewis Numbers #167
Conversation
do some cleanup
defaults for les model coefficients
fix typo
Array4<Real const>(state_arr[box_no], TEMP), | ||
Array4<Real >(cp_arr[box_no]) ); | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to add a Gpu::streamSynchronize() at this point because the multiarrays ParallelFor are non-blocking.
Array4<Real >(mut_arr[box_no]) ); | ||
}); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same Gpu::streamSynchronize() comment here.
Source/PeleLMData.cpp
Outdated
@@ -17,6 +17,14 @@ PeleLM::LevelData::LevelData(amrex::BoxArray const& ba, | |||
press.define( amrex::convert(ba,IntVect::TheNodeVector()), | |||
dm, 1 , 1 , MFInfo(), factory); | |||
visc_cc.define( ba, dm, 1 , 1 , MFInfo(), factory); | |||
if (a_do_les) { | |||
for (int i; i < AMREX_SPACEDIM; ++i) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need int i{0};
otherwise I get uninitialized data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Tested on a couple of simple cases successfully.
Thanks Bruce !
This PR enables LES transport models for scalars and momentum in PeleLMeX. The turbulent viscosity is computed either using constant coefficient Smagorinsky or WALE. Turbulent transport for species and enthalpy are applied using this turbulent viscosity and constant assumed turbulent Schmidt and Prandtl numbers.
A few notes on the implementation: