-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2 new run-time diagnostics: PDF and conditional stats #173
Conversation
PDF and conditional write plain ASCII.
Oh this is an excellent idea! Let me look at the code. |
Lucas, this is fantastic! It's great to be able to dump derived variables using the diagnostics and its better to be able to specify what you need rather than just getting everything. The conditional statistics and PDF capability will also be quite useful. One thing that would be very helpful is to add column headers to the output files and maybe use fixed width formatting to make them more easily human readable (not as important). Additionally, while looking over this I've thought of small wish list of ways to extend/further improve this capability. All these are low priority, but are things I'd add as the use case comes up and I'm recording here so I remember:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of bugs fixed over here (#175) but once that's pulled in this is good to go
@marchdf I'm thinking of moving this to PP and plugging this into PeleC at one point, so I'm interested in your feedback on the interface, maybe too convoluted ?
@baperry2 compared to what you're currently using, you'll need to manually specify a list of variables to output on the 2D plane instead of getting the entire state. There might be a way to add
macro
name that assemble set of variables of interest to make that easier.