Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 new run-time diagnostics: PDF and conditional stats #173

Merged
merged 30 commits into from
Feb 28, 2023

Conversation

esclapez
Copy link
Collaborator

@esclapez esclapez commented Feb 1, 2023

@marchdf I'm thinking of moving this to PP and plugging this into PeleC at one point, so I'm interested in your feedback on the interface, maybe too convoluted ?
@baperry2 compared to what you're currently using, you'll need to manually specify a list of variables to output on the 2D plane instead of getting the entire state. There might be a way to add macro name that assemble set of variables of interest to make that easier.

@marchdf
Copy link
Contributor

marchdf commented Feb 1, 2023

Oh this is an excellent idea! Let me look at the code.

@baperry2
Copy link
Collaborator

baperry2 commented Feb 1, 2023

Lucas, this is fantastic! It's great to be able to dump derived variables using the diagnostics and its better to be able to specify what you need rather than just getting everything. The conditional statistics and PDF capability will also be quite useful.

One thing that would be very helpful is to add column headers to the output files and maybe use fixed width formatting to make them more easily human readable (not as important).

Additionally, while looking over this I've thought of small wish list of ways to extend/further improve this capability. All these are low priority, but are things I'd add as the use case comes up and I'm recording here so I remember:

  • add option for fixed bounds for the conditioning variable similar to what there is for the PDF variable (to enable postprocessing combination of multiple time instances where the extrema are different)
  • add condSq variable when computing integral conditional statistics (to allow computation of the standard deviation when combining data from multiple time instances during postprocessing)
  • add option to internally accumulate conditional statistics/PDFs over time
  • add problem-specific derived variables like in PeleC (https://github.com/AMReX-Combustion/PeleC/blob/d044eec3a6ad65b31b9088673701f37ff0e06a2c/Exec/RegTests/TGReact/prob.H#L151) to allow for custom use of these functions (the use case I have in mind is collecting statistics conditioned on radius for a turbulent jet.)

@esclapez
Copy link
Collaborator Author

esclapez commented Feb 2, 2023

  • header in the ASCII files for PDF/Conditioned stats
  • fixed formatting of ASCII files
  • bounds on conditional variable
  • accumulate stats over time
  • add user-defined derived

Copy link
Collaborator

@baperry2 baperry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of bugs fixed over here (#175) but once that's pulled in this is good to go

@esclapez esclapez marked this pull request as ready for review February 28, 2023 00:18
@esclapez esclapez merged commit 3fd1187 into development Feb 28, 2023
@esclapez esclapez deleted the newDiags branch February 28, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants