Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial Backward facing step flame #196

Merged
merged 11 commits into from
Apr 22, 2023
Merged

Tutorial Backward facing step flame #196

merged 11 commits into from
Apr 22, 2023

Conversation

esclapez
Copy link
Collaborator

No description provided.

@esclapez esclapez requested a review from baperry2 April 18, 2023 19:33
Copy link
Collaborator

@baperry2 baperry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tutorials are awesome! I just fixed some typos in the writeup.


Finally, this case uses Embedded Boundaries to represent the backward facing step. The EB is
defined as a box on the lower-left corner of the domain. For such an easy geometry,
AMReX native simple CGS are sufficient. The box will extend from a point beyond
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear what "AMReX native simple CGS" means here

@esclapez
Copy link
Collaborator Author

Thanks Bruce !

@esclapez esclapez merged commit 5cbf244 into development Apr 22, 2023
@esclapez esclapez deleted the TutorialBFSFlame branch April 22, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants