Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve/remove TODOs throughout the code base #204

Merged
merged 32 commits into from
May 10, 2023
Merged

Resolve/remove TODOs throughout the code base #204

merged 32 commits into from
May 10, 2023

Conversation

esclapez
Copy link
Collaborator

@esclapez esclapez commented May 9, 2023

  • switch to PelePhysics version of the Diagnostics
  • remove TODOs related to Auxiliaries. Will be working on a better way to handle those.

esclapez and others added 26 commits May 1, 2023 17:03
@esclapez
Remove unecessary TODO in Eos.
66bc888
@esclapez
Extra ;
b403c3e
@esclapez
Assert in low level projection function.
66f5876
@esclapez
Remove unused scale from DiffFluxes function.
0075d01
@esclapez
Minor tweaks in Plot functions.
194c10f
@esclapez
Consistent divU number of ghost cells.
d6b12cb
@esclapez
Fix warnings and TODO in diffusion.
7a1ffdf
@esclapez
Make sure to use Factory when defining temporary MFs for derive var
c06c9d2 
and such.
@esclapez
Make vorticity, Qcrit and enstropy derived EB-aware
699326b
@esclapez
Switch to Array4<const Real>.
7550a43
@esclapez
Remove deprecated TODO.
6666018
@esclapez
Odd paste typo.
dcfc4f8
@esclapez
Fix warning in Eos.
55ebe56
@esclapez
Restore alternative method to estimate divU dt and add check.
46d29ad
@esclapez
Update submodules.
39decfc
@esclapez
Add a flag to set EB-covered values to zero in plotfile. Default is ON.
e9bca18
@esclapez
Add an imask in reaction -1 in EB-covered region, 1 otherwise.
acd9a55 
Change default EB-covered state.
@esclapez
Create EB mask only if EB.
3899d1f
@esclapez
Prints in checkDt only on CPU.
1b167ad
@esclapez
Merge branch 'development' into lessTODO
2d20617
@esclapez
Remove unecessary TODO.
c134c8b
@esclapez
Rmove TODO on Aux. Will be handled differently.
e6125d8
@esclapez
Use ParseUserKey to handle domain BCs.
dcd53fb
@esclapez
Merge branch 'development' into lessTODO
2d2c8ab
@esclapez
Remove PeleLMeX version of diagnostics and swtich to PP version.
043f3c6
@esclapez
Enable OMP + GPU chemistry integration.
87a425a
github-advanced-security[bot]
github-advanced-security bot found potential problems May 9, 2023
View reviewed changes
Source/PeleLMSetup.cpp Fixed Show fixed Hide fixed
Source/PeleLMSetup.cpp Fixed Show fixed Hide fixed
@esclapez esclapez marked this pull request as ready for review May 10, 2023 20:05
@esclapez esclapez merged commit 051d58f into development May 10, 2023
@esclapez esclapez deleted the lessTODO branch May 10, 2023 21:42
@baperry2 baperry2 mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@esclapez