-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming LM -> LMeX #257
Renaming LM -> LMeX #257
Conversation
This will require several updates in the Docs: https://amrex-combustion.github.io/PeleLMeX/manual/html/Implementation.html#overview-of-source-code
|
yikes good catch. Wondering if this is a good idea... I did a second pass and I think I caught a bunch more. There's still the input files though... they use controls like |
Looks like I need AMReX-Combustion/PelePhysics#422 first because AMReX-Combustion/PelePhysics#417 broke some things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One consideration would be that we don't want to add friction to remaining LM users transitioning from LM to LMeX now that LM is no longer being supported. But I don't think this adds much to that burden. But I agree, let's not change the parmparse prefix.
No description provided.