Check divu #66
Merged
Check divu #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on; running, but something isnt quite right...
…on; running, but something isnt quite right...
…o check_divu merging development updates into check_divu
* Remove managed arg. from ProbParm * Fix SunMem init. * Add a 3D input file to FlameSheet. * Add timer on SDC k update portion. * Remove mask from inst. RR calculation. EB are handled using box flag and isCovered. * Remove Managed arg from RegTests. * Remove mamged arg. from TripleFlame case.
* Fix Efield BCfill with PMF changes. * Update 1D efield flame source code.
* Enable initializing data from a pltfile, possibly a PeleLM one as long as the mass fractions are stored in there. * Add Extern/amrdata to the list of AMReX packages.
* Setup Tprof regions in advance/oneSDC to get clearer profiling data. * Pass MAGMA flag to TPL and add CUDA ptxas optim. off flag.
* Add a Multi-Component diffusionOp to class. * add ncomp to diffusionOp constructor, default to 1 * getMCDiffusionOp function. if ncomp != m_ncomp, reset the operator. * Reset mcdiffusionOp during regrid. * Enable DiffusionOp::diffuse_scalar, DiffusionOp::computeDiffFluxes and DiffusionOp::computeDiffLap with multiple components. * Switch to getMCDiffusionOp when dealing with species. * NewStateRedist was removed from AMReX-Hydro
* Overhaul level data structure, introducing state MF in place of separate MF for velocity, density, species, ... Fix a bug on the averageDownState function that previously did nothing ... * Restore TurnInflow. Change the process slightly where s_ext now contains the turbulence data coming into bcnormal such that the user can decide to overwrite locally the turbulence if needed. * Set level data I_R to zero if we are not doing divu iters or it could get junk.
* Rmove call to MemHelper initialize. * Add USE_SUNDIALS as preamble to Make.PeleLMeX. * Fix change in the way umac growth faces are filled. * Update submodules.
* Update the convected Species/Temperature gaussian test inputs. * Add missing mean flow direction in Convected Gaussian.
* Add parameter controling the gaussian width based on a diffusion process. * Add parsing. * Update initalization to properly setup the diffusion problem. * Small change to pprocConvOrder.py to aneble hacking the reference solution. * Add an input file to generate the reference analytical solution. * Fix input.2d_DiffGauS for convergence testing.
* Fix parsing tagging input for box. * Couple of fixes for turbinflow for error introduced while re-arranging the level data. * Fix TurbInflow case to match changes in turbinflow velocity field handling. * Add a input file with refinement on loZ.
…on; running, but something isnt quite right...
…on; running, but something isnt quite right...
…o check_divu Finalizing mass injection rebase with development
Add pNew to tempState Update the TurbInflow case with changes in PelePhysics.
esclapez
reviewed
Mar 30, 2022
Source/PeleLMAdvection.cpp
Outdated
| addRhoYFluxes(GetArrOfConstPtrs(fluxes[0]),geom[0]); | ||
| } | ||
| // Compute face domain integral for U | ||
| if (m_sdcIter == m_nSDCmax) { |
There was a problem hiding this comment.
Shoudn't the Umac divergence be done at every SDC step?
There was a problem hiding this comment.
Yeah, good point. Changing...
esclapez
reviewed
Mar 30, 2022
Source/PeleLMEos.cpp
Outdated
Comment on lines
306
to
314
|
|
||
| Vector<MultiFab> dummy(finest_level+1); | ||
| for (int lev = 0; lev <= finest_level; ++lev) { | ||
| dummy[lev].define(grids[lev], dmap[lev], 1, 0, MFInfo(), *m_factory[lev]); | ||
| dummy[lev].setVal(1.0); | ||
| } | ||
|
|
||
| m_uncoveredVol = MFSum(GetVecOfConstPtrs(dummy),0); | ||
|
|
There was a problem hiding this comment.
m_uncoveredVol should already be computed when you come here no ?
esclapez
reviewed
Mar 30, 2022
Source/PeleLMEos.cpp
Outdated
|
|
||
| // subtract \tilde{theta} * Sbar / Thetabar from divu | ||
| for (int lev = 0; lev <= finest_level; ++lev) { | ||
| #ifdef AMREX_USE_OMP | ||
| #pragma omp parallel if (Gpu::notInLaunchRegion()) | ||
| #endif | ||
|
|
There was a problem hiding this comment.
This empty line might mess with #pragma omp parallel if
esclapez
reviewed
Mar 30, 2022
Source/PeleLMTemporals.cpp
Outdated
Comment on lines
31
to
34
| for (int idim = 0; idim < AMREX_SPACEDIM; idim++) { | ||
| m_domainUmacFlux[2*idim] = 0.0; | ||
| m_domainUmacFlux[2*idim+1] = 0.0; | ||
| } |
There was a problem hiding this comment.
This should be done regardless of the m_do_temporal status right ?
There was a problem hiding this comment.
pulling out and placing in PeleLMAdvance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch implements the pressure rise due to enclosed mass injection by summing up velocity flux on all boundary faces and incorporates the correction in adjustPandDivU.