Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative language improvements #158

Merged
merged 27 commits into from
May 4, 2021
Merged

Normative language improvements #158

merged 27 commits into from
May 4, 2021

Conversation

peterbrightwell
Copy link
Contributor

@peterbrightwell peterbrightwell commented Apr 1, 2021

Normative terms (MUST, SHOULD, MAY, etc.) are now all capitalised. Non-normative uses of those terms (which were mostly lower-case) have been replaced or rephrased.

Some other language improvements also included and a little reformatting.

Copy link
Contributor

@garethsb garethsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good editorial changes, Pete. This is a partial review. I'll pick up from docs/3.2. Discovery - Peer to Peer Operation.md next...

docs/1.0. Overview.md Outdated Show resolved Hide resolved
docs/1.0. Overview.md Outdated Show resolved Hide resolved
docs/2.0. APIs.md Outdated Show resolved Hide resolved
docs/2.0. APIs.md Outdated Show resolved Hide resolved
docs/2.0. APIs.md Outdated Show resolved Hide resolved
docs/2.5. APIs - Query Parameters.md Outdated Show resolved Hide resolved
docs/2.5. APIs - Query Parameters.md Outdated Show resolved Hide resolved
docs/3.1. Discovery - Registered Operation.md Outdated Show resolved Hide resolved
docs/3.1. Discovery - Registered Operation.md Outdated Show resolved Hide resolved
docs/3.1. Discovery - Registered Operation.md Outdated Show resolved Hide resolved
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
Copy link
Contributor

@garethsb garethsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 2 review. docs/5.1. Data Model - Identifier Mapping.md next.

docs/3.2. Discovery - Peer to Peer Operation.md Outdated Show resolved Hide resolved
docs/3.2. Discovery - Peer to Peer Operation.md Outdated Show resolved Hide resolved
docs/3.2. Discovery - Peer to Peer Operation.md Outdated Show resolved Hide resolved
docs/4.1. Behaviour - Registration.md Outdated Show resolved Hide resolved
docs/4.1. Behaviour - Registration.md Outdated Show resolved Hide resolved
docs/4.1. Behaviour - Registration.md Outdated Show resolved Hide resolved
docs/4.2. Behaviour - Querying.md Outdated Show resolved Hide resolved
docs/4.2. Behaviour - Querying.md Outdated Show resolved Hide resolved
docs/4.2. Behaviour - Querying.md Outdated Show resolved Hide resolved
docs/4.2. Behaviour - Querying.md Outdated Show resolved Hide resolved
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
Copy link
Contributor

@garethsb garethsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comments. That's it for a first pass.

docs/5.1. Data Model - Identifier Mapping.md Outdated Show resolved Hide resolved
docs/5.1. Data Model - Identifier Mapping.md Outdated Show resolved Hide resolved
docs/6.0. Upgrade Path.md Outdated Show resolved Hide resolved
docs/6.0. Upgrade Path.md Outdated Show resolved Hide resolved
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
docs/1.0. Overview.md Outdated Show resolved Hide resolved
peterbrightwell and others added 6 commits April 2, 2021 19:11
* Using backticks in 2.1
* Backticks for 2.3, 2.4, 2.5
* Backticks for 3.0,3.1,3.2
* Backticks for 4.2,4.3
* Backticks for 5.1,6.0
* backticks for GET etc
* Headers
* Colons
* HTTP verbs
* More backtick/quote/apostrophe fixes
* Add description consistently to all specific HTTP status codes in the docs.
* i.e. id est
* Don't use capitals for emphasis (apart from conformance language key words)
* Attributes are within resources not the path...
* More backticks on query parameters and HTTP headers
* More backticks on attributes and URL path components
* Backtick JSON keywords `null`, `true` and `false`

Co-authored-by: garethsb <gareth.sylvester-bradley@sony.com>
* Backtick HTTP return codes
* Backtick HTTP return codes in CHANGELOG
* Apply suggestions from code review

Co-authored-by: garethsb <gareth.sylvester-bradley@sony.com>
@garethsb
Copy link
Contributor

garethsb commented Apr 7, 2021

Things that I think are outstanding:

Sync example URL with IS-05 PR.
Co-authored-by: Andrew Bonney <andrew.bonney@bbc.co.uk>
@peterbrightwell
Copy link
Contributor Author

AMWA-TV/is-template#19 suggests a style guide

* Possible alternative language on Query API Behaviour

* Suggested changes to Query API WebSocket Subscriptions documentation

* Capitalizing Subscription

Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
@garethsb garethsb self-requested a review May 4, 2021 15:22
Copy link
Contributor

@garethsb garethsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. 🤞

@peterbrightwell peterbrightwell merged commit 58fb9f4 into v1.3.x May 4, 2021
@peterbrightwell peterbrightwell deleted the docs-language branch May 4, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants