-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative language improvements #158
Conversation
403fcb1
to
048aa9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of good editorial changes, Pete. This is a partial review. I'll pick up from docs/3.2. Discovery - Peer to Peer Operation.md next...
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 2 review. docs/5.1. Data Model - Identifier Mapping.md next.
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more comments. That's it for a first pass.
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
* Using backticks in 2.1 * Backticks for 2.3, 2.4, 2.5 * Backticks for 3.0,3.1,3.2 * Backticks for 4.2,4.3 * Backticks for 5.1,6.0 * backticks for GET etc * Headers * Colons * HTTP verbs * More backtick/quote/apostrophe fixes * Add description consistently to all specific HTTP status codes in the docs. * i.e. id est * Don't use capitals for emphasis (apart from conformance language key words) * Attributes are within resources not the path... * More backticks on query parameters and HTTP headers * More backticks on attributes and URL path components * Backtick JSON keywords `null`, `true` and `false` Co-authored-by: garethsb <gareth.sylvester-bradley@sony.com>
* Backtick HTTP return codes * Backtick HTTP return codes in CHANGELOG * Apply suggestions from code review Co-authored-by: garethsb <gareth.sylvester-bradley@sony.com>
Things that I think are outstanding:
|
Sync example URL with IS-05 PR.
Co-authored-by: Andrew Bonney <andrew.bonney@bbc.co.uk>
AMWA-TV/is-template#19 suggests a style guide |
* Possible alternative language on Query API Behaviour * Suggested changes to Query API WebSocket Subscriptions documentation * Capitalizing Subscription Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. 🤞
Normative terms (MUST, SHOULD, MAY, etc.) are now all capitalised. Non-normative uses of those terms (which were mostly lower-case) have been replaced or rephrased.
Some other language improvements also included and a little reformatting.