Use parking_lot #82
Closed
Use parking_lot #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parking_lot provides much faster and smaller primitives than Rust's std. During thread panic, these locks do not get poisoned and hence we can remove all the explicit care that we had to put to handle poisoning. Also once_cell can also leverage parking_lot's types for smaller Lazy types. This PR moves all the usage of std'd Mutex and other sync types to parking_lot's equivalent types. This PR also fixes a bug where calling `dynamic_paging` or `static_paging` will cause a panic since the value of OnceCell is already set and we cannot mutate it without using unsafe
We also used AtomicBool where it would have been a better choice than a parking_lot type
|
Merged locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces parking_lot sync primitives to replace Rust's
stdtypes for faster and much smaller sync types.This also fixes a bug where calling
dynamic_pagingorstatic_pagingagain after the first pager would cause a panic.