ENH: Make eccentricity more similar to elongation #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1733
Given a 3D object with principal moments V_0 <= V_1 <= V_2, itkShapeLabelMapFilter computes elongation as sqrt(V_2 / V_1).
It doesn't compute eccentricity, so I had added that to LabelGeometryMeasures as sqrt(1 - V_2^2 / V_0^2).
But I think it might be better to use sqrt(1 - V_2^2 / V_1^2), so that it works on the same moments as the elongation. For cortex and other thin structures, the relative shape of the longer sides are often more interesting anyway.
The new filter also has roundness, which is a measure of similarity to a sphere and considers all three axes.