Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtraction methods fail in aslAveraging #319

Open
s-kash opened this issue May 27, 2020 · 8 comments
Open

Subtraction methods fail in aslAveraging #319

s-kash opened this issue May 27, 2020 · 8 comments

Comments

@s-kash
Copy link

s-kash commented May 27, 2020

Hi ANTsR team,

Describe the bug
I'm trying the ASL processing tools available in ANTsR. Particularly to obtain pair-wise differences of a timeseries. I want to compare the different perfusion subtraction methods available. However, all four: "simpleSubtract","surroundSubtract","cubicSubtract" and ""sincSubtract" all crash with the following error message (example for one method):

ITK ExceptionObject caught!
Error in aslAveraging(input_asl, mask = NULL, method = "surroundSubtract") :
/usr/local/lib/R/site-library/ITKR/libs/include/ITK-5.1/itkImageSource.hxx:268:
itk::ERROR: AverageOverDimensionImageFilter(0x563b5e72cf10): Subclass should override this method!!! If old behavior is desired invoke this->DynamicMultiThreadingOff(); before Update() is called. The best place is in class constructor.

To Reproduce
Steps to reproduce the behavior:
input_asl <- antsImageRead("test_asl_timeseries.nii.gz")
perf_asl_surrsub <- aslAveraging(input_asl, mask = NULL, method = "surroundSubtract")

Expected behavior
I expect the command to provide the temporal mean of the pair-wise difference of the ASL time-series. Isn't this right? Although, I'd prefer it give me the entire pair-wise difference time-series (before averaging) as well.

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser: Chrome
  • Version: 18.04.4

Additional context
Rstudio v 1.2.5001 and R version 3.6.3

Help is appreciated.

Thanks,
Sri

@stnava
Copy link
Member

stnava commented Jul 16, 2020

@jeffduda any chance. you could take a look at this?

@jeffduda
Copy link
Collaborator

jeffduda commented Jul 16, 2020 via email

@stnava
Copy link
Member

stnava commented Jul 16, 2020 via email

@jeffduda
Copy link
Collaborator

jeffduda commented Jul 16, 2020 via email

@stnava
Copy link
Member

stnava commented Jul 16, 2020 via email

@jeffduda
Copy link
Collaborator

jeffduda commented Jul 19, 2020 via email

@jeffduda
Copy link
Collaborator

jeffduda commented Jul 20, 2020 via email

@stnava
Copy link
Member

stnava commented Jul 20, 2020

that sounds good - I just tested the surround subtract and it worked in the sense that it did not crash. will try some time later this month on real data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants