Add Travis-CI automated tests #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Plus, add badges to README
* jQuery ~ upgrade version 2.1.4 to 3.3.1; * QUnit Javascript ~ 1.18.0 to 2.6.1;
|
Thank you very much @nfreear. That's why I like open source sooo much. Had it on my mind for weeks now to integrate travis-ci and finally you did it. |
|
Happy to help @BernhardBehrendt. Btw, I realised that I shouldn't have put jQuery in I have some other ideas / pull requests to follow. Yours, Nick |
nfreear
added a commit
to nfreear/cookie-notice
that referenced
this pull request
May 29, 2018
…clarity * Also move QUnit from peer to `devDependencies` * AOEpeople#1
BernhardBehrendt
added a commit
that referenced
this pull request
May 29, 2018
Follow-up to pull #1 - move jQuery to `devDependencies` for clarity
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @micc83 and @BernhardBehrendt,
Thank you for all your work on the
cookie-noticeJavascript - very useful!I've added a
.travis.ymlconfiguration, in order to run the QUnit tests that you've written on each build. See:nfreear/cookie-noticeandnfreear/cookie-noticebuild # 384...034And, I've added the Travis-CI "pass" / "fail" badge to the README ...
(Obviously, if you merge, you can/should setup Travis-CI yourselves, and use that badge ... give me a shout, or try the help.)
I hope this helps. More soon!
Best wishes,
Nick