New design #96
Merged
New design #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shubertm please mark this PR with new label |
|
SVID_20240616_203207_1.mp4
|
hieuwu
reviewed
Jun 19, 2024
| @Query("SELECT * FROM RoomAsset") | ||
| fun allFlow(): Flow<List<RoomAsset>> | ||
|
|
||
| @Query("DELETE FROM RoomAsset where id = :id") |
There was a problem hiding this comment.
Suggested change
| @Query("DELETE FROM RoomAsset where id = :id") | |
| @Query("DELETE FROM RoomAsset WHERE id = :id") |
|
|
||
| @Dao | ||
| interface PortfolioDao { | ||
| @Insert(onConflict = OnConflictStrategy.REPLACE) |
There was a problem hiding this comment.
This could be replaced with @Upsert annotation
Suggested change
| @Insert(onConflict = OnConflictStrategy.REPLACE) | |
| @Upsert |
app/src/main/java/dev/arkbuilders/rate/data/db/PairAlertRepoImpl.kt
Outdated
Show resolved
Hide resolved
| @Insert(onConflict = OnConflictStrategy.REPLACE) | ||
| suspend fun insert(pairAlert: RoomPairAlert): Long | ||
|
|
||
| @Query("SELECT * FROM RoomPairAlert where id = :id") |
There was a problem hiding this comment.
Suggested change
| @Query("SELECT * FROM RoomPairAlert where id = :id") | |
| @Query("SELECT * FROM RoomPairAlert WHERE id = :id") |
app/src/main/java/dev/arkbuilders/rate/data/db/PairAlertRepoImpl.kt
Outdated
Show resolved
Hide resolved
@shubertm |
design fixes fix clickable area
filter feature, create new pair from existed pair and code
inter font, fixes
fix bottom nav design
Firebase setup, track screen usage, remove ACRA revert fix Webview data directory suffix crash (caused by ACRA) ui fixes
Fix empty screen btn padding
minor fixes
white navigation bar intercept clicks on snackbar background sort CurrencyName by code in repo Quick item second icon fix fix fiat icons ui fix: center currency name if no description discord link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.