#41: Add unit tests, fix update_one #72

kirillt · 2024-01-20T11:11:54Z

Here are couple more tests.

update_one was handling absent paths incorrectly, fixed here.

Closing:

Ensure that update_all and update_one are consistent #41

src/index.rs

kirillt · 2024-01-20T11:19:55Z

correct comparison of generic path against fixed-typed path
implement automatic test by this idea
#41: Make unit tests of update_one and update_all method #71 (comment)

src/index.rs

funnyVOLT · 2024-01-23T03:15:42Z

@kirillt
I would like to inform you of my opinion.
The problem occurred while comparing 'update_all' and 'track_methods'.

When a new file is created.
When files with the same ResourceID are added, update_all and track_addition operate differently.
When a new file is modified
After the file is changed, update_all does not seem to reflect the changed information.
The handling of collisions in the 'track_update' function is not reflected clearly.
Overall, I think we need to check 'collisions' again.

kirillt · 2024-01-24T15:46:48Z

@funnyVOLT thank you for the test case. I'll look into it deeper soon. It's great that you've discovered corner cases I've missed!

Could you create small isolated test cases reproducing these 2 problems?

When files with the same ResourceID are added, update_all and track_addition operate differently.

After the file is changed, update_all does not seem to reflect the changed information.

funnyVOLT · 2024-01-24T18:28:06Z

@funnyVOLT thank you for the test case. I'll look into it deeper soon. It's great that you've discovered corner cases I've missed!

Could you create small isolated test cases reproducing these 2 problems?

When files with the same ResourceID are added, update_all and track_addition operate differently.

After the file is changed, update_all does not seem to reflect the changed information.

@kirillt , I've pushed test case codes.

src/index.rs

kirillt · 2024-02-01T00:33:43Z

src/index.rs

+            // create
+            1 => {
+                let mut file_name_new = String::from(cur_file_name);
+                file_name_new.push_str("_new.txt");


Would be better to provide new random unique name, automatically.

Would be better to provide new random unique name, automatically.

I added const variable CREATE, UPDATE, DELETE, MOVE .

src/index.rs

kirillt · 2024-02-01T00:36:46Z

src/index.rs

+        let mut folder_1 = root_path.clone();
+        let mut folder_2 = root_path.clone();
+        folder_1.push(FILE_DIR_1);
+        folder_2.push(FILE_DIR_2);


Do we really need 2 folders?

Do we really need 2 folders?

It is necessary for file movement function.

We can also just move to new random filename. This way we can apply move operation multiple times, no need to track in which of the two the file resides.

src/index.rs

kirillt · 2024-02-05T11:09:36Z

src/index.rs

    const FILE_NAME: &str = "test_";
-    const FILE_COUNT: i32 = 10;
+    const FILE_COUNT: i32 = 3;


Isn't 3 too few for proper testing?

kirillt · 2024-02-05T11:12:56Z

src/index.rs

@@ -1320,7 +1319,7 @@ mod tests {
                .update_all()
                .expect("Should update index correctly");

-            assert_eq!(index_track_addition, index_update_all);
+            assert_ne!(index_track_addition, index_update_all);


Must be equal, isn't it?

kirillt · 2024-02-05T11:21:32Z

src/index.rs

+                .update_all()
+                .expect("Should update index correctly");
+
+            assert_ne!(


After this assertion we should sleep for 1ms, perform update_all again and assert_eq new index.

regarding this test,
Why should the result from track_addition and update_all be different?

tareknaser

Great job!
Left some comments.

I think we can also add simple doc comments on the methods implemented for ResourceIndex

src/index.rs

tareknaser

some more comments but we are getting there

src/index.rs

tareknaser · 2024-02-07T10:21:52Z

src/index.rs

+            crc32: CRC32_2,
+        }
+    }
+
    fn run_test_and_clean_up(


I am not sure we need this function
we can use TempDir::new to achieve the same output

tempdir crate automatically cleans up the temporary directories when they go out of scope

I will leave this one for a follow up PR

tareknaser · 2024-02-07T10:33:13Z

src/index.rs

+                match update_state.try_into() {
+                    Ok(FileAction::CREATE) => {
+                        let _ = index1.track_addition(&new_file_path);
+                    }
+                    Ok(FileAction::UPDATE) => {
+                        let _ = index1.track_update(&file_path, old_id);
+                    }
+                    Ok(FileAction::DELETE) => {
+                        let _ = index1.track_deletion(old_id);
+                    }
+                    Ok(FileAction::MOVE) => {
+                        let _ = index1.track_deletion(old_id);
+                        let _ = index1.track_addition(&new_file_path);
+                    }
+                    Err(_) => println!("rnd_num error"),
+                }


Are we intentionally ignoring errors here for testing purposes?

If not, we should panic with errors

Suggested change

match update_state.try_into() {

Ok(FileAction::CREATE) => {

let _ = index1.track_addition(&new_file_path);

}

Ok(FileAction::UPDATE) => {

let _ = index1.track_update(&file_path, old_id);

}

Ok(FileAction::DELETE) => {

let _ = index1.track_deletion(old_id);

}

Ok(FileAction::MOVE) => {

let _ = index1.track_deletion(old_id);

let _ = index1.track_addition(&new_file_path);

}

Err(_) => println!("rnd_num error"),

}

match update_state.try_into() {

Ok(FileAction::CREATE) => {

index1

.track_addition(&new_file_path)

.expect("Should track addition correctly");

}

Ok(FileAction::UPDATE) => {

index1

.track_update(&file_path, old_id)

.expect("Should track update correctly");

}

Ok(FileAction::DELETE) => {

index1

.track_deletion(old_id)

.expect("Should track deletion correctly");

}

Ok(FileAction::MOVE) => {

index1

.track_deletion(old_id)

.expect("Should track deletion correctly");

index1

.track_addition(&new_file_path)

.expect("Should track addition correctly");

}

Err(_) => println!("rnd_num error"),

}

@tareknaser yes, we must panic and not ignore the errors. But maybe simple unwrapping would be fine in test code?

tareknaser · 2024-02-07T10:33:40Z

src/index.rs

+
+            let mut added_file_path = path.clone();
+            added_file_path.push(FILE_NAME_2);
+            let _ = index_track_addition.track_addition(&added_file_path);


Here as well

src/index.rs

Signed-off-by: Tarek <tareknaser360@gmail.com>

kirillt · 2024-09-16T22:41:10Z

The scope of this PR was split and reworked in new repo:

kirillt mentioned this pull request Jan 20, 2024

#41: Make unit tests of update_one and update_all method #71

Closed

kirillt commented Jan 20, 2024

View reviewed changes

src/index.rs Outdated Show resolved Hide resolved

kirillt commented Jan 21, 2024

View reviewed changes

src/index.rs Outdated Show resolved Hide resolved

kirillt mentioned this pull request Jan 21, 2024

#41: update_one tests #52

Closed

kirillt assigned funnyVOLT Jan 22, 2024

kirillt mentioned this pull request Jan 22, 2024

Index update one ARK-Builders/arklib-android#91

Open

ARK-Builders deleted a comment from Kirill Jan 25, 2024

ARK-Builders deleted a comment from funnyVOLT Jan 25, 2024

kirillt commented Feb 1, 2024

View reviewed changes

src/index.rs Outdated Show resolved Hide resolved

kirillt commented Feb 1, 2024

View reviewed changes

src/index.rs Outdated Show resolved Hide resolved

kirillt commented Feb 1, 2024

View reviewed changes

src/index.rs Outdated Show resolved Hide resolved

kirillt commented Feb 1, 2024

View reviewed changes

src/index.rs Outdated Show resolved Hide resolved

kirillt commented Feb 1, 2024

View reviewed changes

funnyVOLT added a commit to funnyVOLT/arklib that referenced this pull request Feb 1, 2024

issue ARK-Builders#72 unique new file name, cargo fmt

f6885cb

kirillt commented Feb 1, 2024

View reviewed changes

src/index.rs Outdated Show resolved Hide resolved

kirillt commented Feb 1, 2024

View reviewed changes

src/index.rs Outdated Show resolved Hide resolved

kirillt commented Feb 1, 2024

View reviewed changes

src/index.rs Outdated Show resolved Hide resolved

kirillt commented Feb 1, 2024

View reviewed changes

src/index.rs Outdated Show resolved Hide resolved

kirillt commented Feb 5, 2024

View reviewed changes

tareknaser suggested changes Feb 5, 2024

View reviewed changes

kirillt assigned tareknaser and unassigned funnyVOLT Feb 6, 2024

kirillt changed the title ~~Add unit tests, fix update_one~~ #41: Add unit tests, fix update_one Feb 6, 2024

tareknaser reviewed Feb 7, 2024

View reviewed changes

tareknaser mentioned this pull request Feb 7, 2024

Test Clean-Up necessary #80

Closed

test(index): add unit tests and fix update_one

76b3389

Signed-off-by: Tarek <tareknaser360@gmail.com>

tareknaser force-pushed the index/update-one branch from b3205f2 to 76b3389 Compare February 11, 2024 18:03

kirillt mentioned this pull request Feb 19, 2024

Refactor src/index.rs and Enhance Documentation #87

Merged

kirillt mentioned this pull request May 11, 2024

Add watch_index method and ark-cli watch command ARK-Builders/ark-core#36

Open

kirillt mentioned this pull request Jul 22, 2024

fs-index: Track API ARK-Builders/ark-core#84

Closed

kirillt closed this Sep 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#41: Add unit tests, fix update_one #72

#41: Add unit tests, fix update_one #72

kirillt commented Jan 20, 2024 •

edited

Loading

kirillt commented Jan 20, 2024 •

edited

Loading

funnyVOLT commented Jan 23, 2024 •

edited by kirillt

Loading

kirillt commented Jan 24, 2024

funnyVOLT commented Jan 24, 2024 •

edited

Loading

kirillt Feb 1, 2024

funnyVOLT Feb 1, 2024

kirillt Feb 1, 2024

funnyVOLT Feb 1, 2024

kirillt Feb 2, 2024

kirillt Feb 5, 2024 •

edited

Loading

kirillt Feb 5, 2024

kirillt Feb 5, 2024

tareknaser Feb 7, 2024

tareknaser left a comment

tareknaser left a comment

tareknaser Feb 7, 2024

tareknaser Feb 10, 2024

tareknaser Feb 7, 2024

kirillt Apr 10, 2024

tareknaser Feb 7, 2024

kirillt commented Sep 16, 2024

#41: Add unit tests, fix update_one #72

#41: Add unit tests, fix update_one #72

Conversation

kirillt commented Jan 20, 2024 • edited Loading

kirillt commented Jan 20, 2024 • edited Loading

funnyVOLT commented Jan 23, 2024 • edited by kirillt Loading

kirillt commented Jan 24, 2024

funnyVOLT commented Jan 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kirillt Feb 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tareknaser left a comment

Choose a reason for hiding this comment

tareknaser left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kirillt commented Sep 16, 2024

kirillt commented Jan 20, 2024 •

edited

Loading

kirillt commented Jan 20, 2024 •

edited

Loading

funnyVOLT commented Jan 23, 2024 •

edited by kirillt

Loading

funnyVOLT commented Jan 24, 2024 •

edited

Loading

kirillt Feb 5, 2024 •

edited

Loading