refactor(crypto): overwrite arrays when merging milestones #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dated
requested review from
air1one,
faustbrian,
kristjank and
spkjp
as code owners
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
|
Thanks! Can you also try to write tests for what you mentioned in #3105 and here? The relevant tests would have to be added here: |
spkjp
approved these changes
Oct 24, 2019
|
A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
|
Your pull request has been merged and marked as tier 3. It will earn you $50 USD. |
ghost
mentioned this pull request
faustbrian
pushed a commit
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of concatenating arrays, overwrite them with the
sourcearray. In the particular case ofminimumVersionswe don't want to keep older values around, this PR is a solution targeted at this case and is not intended as a general solution for merging arrays - although as of now theminimumVersionsarray is the only array used in milestones.Possibly closes #3105.
Checklist