Feature/update query vts most recent #5
Conversation
PeterRimmer71
requested review from
alessiorucconi,
AndreaCuneo,
MicheleNan and
MarcoGix
|
|
||
| query = requests.getQs() | ||
| self.assertEqual(query["fillerK"],"Null") |
There was a problem hiding this comment.
asserts are not checking on the MostRecent part of the query (the url)
am I missing something?
There was a problem hiding this comment.
I think I'm missing something! I don't know how to build the query (I figure that's the URL). I tried adding ForMostRecent with/without dates etc. but I'm kind of shooting in the dark. I'm not that familiar with Python. Plus I don't know how to run the tests in debug mode so I can't observe the query to get an idea of how to modify the query.
There was a problem hiding this comment.
Me neither, but I'm sure someone in your team does, as someone did this code.
The point is that you added tests related to updating the MostRecent with something, not clear from PR. I know that is related to the time part but I don't see any checks that the created url is as expected.
You added test case but you didn't tested them?
Task: Update the Python SDK with the new feature https://dev.azure.com/arklabita/ProjectONE/_sprints/backlog/418%20Teapot%20Team/ProjectONE/418%20Teapot%20Team/Week%2037-38%202021?workitem=7330