Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix Vector Multiplication fails for large matrix size #118

Closed
yuvpg opened this issue Sep 19, 2023 · 2 comments
Closed

Matrix Vector Multiplication fails for large matrix size #118

yuvpg opened this issue Sep 19, 2023 · 2 comments
Labels
bug Something isn't working DONE Issue done but not yet closed

Comments

@yuvpg
Copy link

yuvpg commented Sep 19, 2023

arm_mat_vec_mult_f32() fails to produce correct output if rowCount*colCount > 65536

There is a bug in definition of a loop counter:

uint16_t i, row, colCnt; /* loop counters */    <-- should be uint32_t

https://github.com/ARM-software/CMSIS-DSP/blob/cb0960577d6483a2a626ae5d8778b6f00a844b32/Source/MatrixFunctions/arm_mat_vec_mult_f32.c#L301C5-L301C14
@christophe0606 christophe0606 added the bug Something isn't working label Sep 20, 2023
@christophe0606
Copy link
Contributor

@yuvpg Thanks for reporting this.

christophe0606 added a commit that referenced this issue Nov 27, 2023
@christophe0606
Corrected issue #118
0365807
@christophe0606 christophe0606 added the DONE Issue done but not yet closed label Nov 27, 2023
@christophe0606
Copy link
Contributor

It should be fixed in latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working DONE Issue done but not yet closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christophe0606 @yuvpg