Suggestion to add exact sum functions in BasicMathFunctions folder #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correction of mistakes
|
@Silfurion I'll need to write and add some tests before I can merge this PR. |
|
There were some pending questions in this PR. Accumulation functions are now tracked in this new github issues on the new CMSIS-DSP repository : ARM-software/CMSIS-DSP#12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In some of our projects, we would like to accelerate the sum of vector elements. At the moment CMSIS doesn't offer a simple sum function. The closest method was the mean method that unfortunately doesn't offer an exact result if we want to multiply its result by the size of the array to get back the sum of the vector.
With this pull request we would like to suggest the addition of a new sum function that would allow to benefit from the already implemented and accelerated mean function, but without the final division to obtain a more accurate sum result.
We added these function in the BasicMathFunctions folder available for q7 , q15 , q31 , float16 , float32 and float64.
Thanks again