Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #37: Resolve MXML from target system by pkg-config when not usi… #39

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

bengaineyarm
Copy link
Contributor

…ng vcpkg

@clementperon
Copy link
Contributor

clementperon commented Dec 16, 2022

@bengaineyarm the config works fine but the build still fails not related to this MR

$> cmake -DENABLE_VCPKG=OFF ..
$> cmake --build . 
BufferUtils.h:6:10: error: 'cstddef' file not found [clang-diagnostic-error]
#include <cstddef>
         ^~~~~~~~~
1 error generated.

@bengaineyarm
Copy link
Contributor Author

@clementperon - odd, what compiler (and version) are you using? Possibly this is coming from clang-tidy being enabled by default. Can you reconfigure cmake with the addition of -DENABLE_CLANG_TIDY_DURING_BUILD=OFF and let me know if you get the same error.
Not entirely clear why clang-tidy can't find cstddef though... its not exactly an unusual header.

@clementperon
Copy link
Contributor

@clementperon - odd, what compiler (and version) are you using? Possibly this is coming from clang-tidy being enabled by default. Can you reconfigure cmake with the addition of -DENABLE_CLANG_TIDY_DURING_BUILD=OFF and let me know if you get the same error. Not entirely clear why clang-tidy can't find cstddef though... its not exactly an unusual header.

You're right configuring with -DENABLE_CLANG_TIDY_DURING_BUILD=OFF fix the issue

$> clang-tidy --version
Ubuntu LLVM version 14.0.0
  
  Optimized build.
  Default target: x86_64-pc-linux-gnu
  Host CPU: znver3
  
$> c++ --version
c++ (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

@bengaineyarm
Copy link
Contributor Author

Thanks @clementperon - I'll make another version, that disables clang-tidy by default to simplify the issue, since sanitizer warnings are mostly my problem rather than yours, then merge that.

Thanks for help testing / validating.

Its mostly for developers not users, so adds to the build time
unnecessarily. Plus it appears to fail in some cases by not being
able to locate std library headers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants