Update the I2C test to use I2CEeprom driver API from github #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbeyond
reviewed
Mar 6, 2020
TESTS/API/I2C/I2C.cpp
Outdated
| char test = 'A' + rand()%26; | ||
| char read; | ||
| int r = 0; | ||
| int w = 0; | ||
| w = memory.write(address,test); | ||
| r = memory.read(address,read); | ||
| w = memory.program((const void *)test, address, sizeof(test)); |
There was a problem hiding this comment.
test is not a pointer, why cast to void* ?
There was a problem hiding this comment.
ARMmbed/i2cee-driver#6 is merged.
But this I2CEeprom did not pass, can you fixed the test? @rajkan01
@jamesbeyond good catch. fixed the issue
|
ARMmbed/i2cee-driver#6 is merged. |
rajkan01
force-pushed
the
i2ceeprom_api_adaption
branch
from
a4eef21
to
a6c1c74
Compare
evedon
requested changes
Mar 10, 2020
|
Qinghao suggested to change https://github.com/ARMmbed/ci-test-shield/blob/master/LM75B.lib pointing to https://github.com/ARMmbed/LM75B |
rajkan01
force-pushed
the
i2ceeprom_api_adaption
branch
2 times, most recently
from
d6c4928
to
eb23f45
Compare
|
can you put the SHA of ARMmbed/LM75B@bf2c530 |
evedon
approved these changes
Mar 11, 2020
rajkan01
force-pushed
the
i2ceeprom_api_adaption
branch
from
eb23f45
to
a267d3f
Compare
jamesbeyond
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ci test shield I2C test to use latest I2CEeprom driver API from GitHub instead of using legacy I2C Eeprom driver API from Mercurial.