PwmOut.h: Added destructor and call to pwmout_free in HAL. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please consider whether this means this class should be implementing other operators too: cf. rule of 3/5: https://en.wikipedia.org/wiki/Rule_of_three_(C%2B%2B_programming) |
|
@autopulated Yes, both the copy and assignment operator should be implemented. |
|
Other operators can come later. This is basic functionality that is required. |
|
With this change, we should explicitly delete the copy and move constructors, the copy and move assignment operators. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destructor is necessary to achieve low power on the Wearable Reference Design.