Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Experimental Services Example #346

Closed
wants to merge 6 commits into from
Closed

Add Experimental Services Example #346

wants to merge 6 commits into from

Conversation

noonfom
Copy link

@noonfom noonfom commented Nov 26, 2020

This example demonstrates the Link Loss and Current Time Services from the Experimental BLE Services repository.

@noonfom noonfom changed the title Add link loss service example Add Link Loss Service example Nov 26, 2020
@paul-szczepanek-arm paul-szczepanek-arm changed the base branch from master to development November 27, 2020 08:34
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work on the readme, I'm afraid you've set the bar high for the following services :)

BLE_GattServer_ExperimentalServices/README.md Outdated Show resolved Hide resolved
BLE_GattServer_ExperimentalServices/README.md Outdated Show resolved Hide resolved
BLE_GattServer_ExperimentalServices/README.md Outdated Show resolved Hide resolved
BLE_GattServer_ExperimentalServices/README.md Outdated Show resolved Hide resolved
BLE_GattServer_ExperimentalServices/README.md Outdated Show resolved Hide resolved
BLE_GattServer_ExperimentalServices/source/main.cpp Outdated Show resolved Hide resolved
BLE_GattServer_ExperimentalServices/source/main.cpp Outdated Show resolved Hide resolved
BLE_GattServer_ExperimentalServices/README.md Outdated Show resolved Hide resolved
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple small changes needed

BLE_GattServer_ExperimentalServices/.mbed Outdated Show resolved Hide resolved
BLE_GattServer_ExperimentalServices/README.md Outdated Show resolved Hide resolved
BLE_GattServer_ExperimentalServices/source/main.cpp Outdated Show resolved Hide resolved
Comment on lines 19 to 20
#include "mbed-os-ble-utils/pretty_printer.h"
#include "mbed-os-experimental-ble-services/services/inc/LinkLossService.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needs fixing

@@ -0,0 +1 @@
https://github.com/ARMmbed/mbed-os/#8ef0a435b2356f8159dea8e427b2935d177309f8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needs fixing

@paul-szczepanek-arm
Copy link
Member

This depends on ARMmbed/mbed-os-experimental-ble-services#14 going in first.

@noonfom noonfom changed the title Add Link Loss Service example Add Experimental Services Example Dec 23, 2020
Abbas Bracken Ziad added 2 commits December 24, 2020 12:46
Remove last bullet point
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just missing the lib in the requires

BLE_GattServer_ExperimentalServices/mbed_app.json Outdated Show resolved Hide resolved
const static char DEVICE_NAME[] = "ExperimentalServices";

static events::EventQueue event_queue(/* event count */ 10 * EVENTS_EVENT_SIZE);
static ChainableGapEventHandler chainable_gap_event_handler;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that important but this could just be a member variable of LinkLossDemo

Abbas Bracken Ziad and others added 2 commits December 28, 2020 19:10
- Add lib in requires
- Change name of demo class
- Add captions to remaining figures
- Correct current time images
symlink is breaking CI
@paul-szczepanek-arm
Copy link
Member

Superseded by: #349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants