-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Experimental Services Example #346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work on the readme, I'm afraid you've set the bar high for the following services :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple small changes needed
#include "mbed-os-ble-utils/pretty_printer.h" | ||
#include "mbed-os-experimental-ble-services/services/inc/LinkLossService.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needs fixing
@@ -0,0 +1 @@ | |||
https://github.com/ARMmbed/mbed-os/#8ef0a435b2356f8159dea8e427b2935d177309f8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needs fixing
This depends on ARMmbed/mbed-os-experimental-ble-services#14 going in first. |
Remove last bullet point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just missing the lib in the requires
const static char DEVICE_NAME[] = "ExperimentalServices"; | ||
|
||
static events::EventQueue event_queue(/* event count */ 10 * EVENTS_EVENT_SIZE); | ||
static ChainableGapEventHandler chainable_gap_event_handler; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not that important but this could just be a member variable of LinkLossDemo
- Add lib in requires - Change name of demo class - Add captions to remaining figures - Correct current time images
symlink is breaking CI
Superseded by: #349 |
This example demonstrates the Link Loss and Current Time Services from the Experimental BLE Services repository.