-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: Add requirements.txt file for required Python modules #13944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
Indentifies a PR as containing just a patch
label
Nov 23, 2020
@0xc0170, thank you for your changes. |
@rajkan01 Please review |
0xc0170
force-pushed
the
cmake-requirements
branch
from
December 3, 2020 15:15
b9cf702
to
d3a5279
Compare
2 tasks
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
hugueskamba
previously approved these changes
Dec 16, 2020
The memmap script depends on external Python modules. The added file captures the required packages to be installed.
hugueskamba
force-pushed
the
cmake-requirements
branch
from
December 16, 2020 13:46
d3a5279
to
006eff5
Compare
mergify
bot
dismissed
hugueskamba’s stale review
December 16, 2020 13:47
Pull request has been modified.
hugueskamba
changed the title
CMake: add requirements
CMake: Add requirements.txt file for required Python modules
Dec 16, 2020
hugueskamba
approved these changes
Dec 16, 2020
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
Release-pending
and removed
release-type: patch
Indentifies a PR as containing just a patch
Release-pending
labels
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The memmap script depends on external Python modules.
The added file captures the required packages to be installed.
One question: where we capture what we use (memmap dependency is not clear) ? Shall I add a note about additional cmake dependencies to our readme?
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers