Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Add requirements.txt file for required Python modules #13944

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Nov 23, 2020

Summary of changes

The memmap script depends on external Python modules.
The added file captures the required packages to be installed.

One question: where we capture what we use (memmap dependency is not clear) ? Shall I add a note about additional cmake dependencies to our readme?

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 23, 2020
@ciarmcom ciarmcom requested review from a team November 23, 2020 13:30
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 3, 2020

@rajkan01 Please review

@mergify
Copy link

mergify bot commented Dec 11, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

hugueskamba
hugueskamba previously approved these changes Dec 16, 2020
The memmap script depends on external Python modules.
The added file captures the required packages to
be installed.
@mergify mergify bot dismissed hugueskamba’s stale review December 16, 2020 13:47

Pull request has been modified.

@hugueskamba hugueskamba changed the title CMake: add requirements CMake: Add requirements.txt file for required Python modules Dec 16, 2020
@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 16, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 16, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 383818c into ARMmbed:master Dec 17, 2020
@0xc0170 0xc0170 deleted the cmake-requirements branch December 17, 2020 10:27
@mergify mergify bot removed the ready for merge label Dec 17, 2020
@mbedmain mbedmain added Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants