-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target RTL8710AF #7965
Add target RTL8710AF #7965
Conversation
What is not correct, an issue reported anywhere? |
This is doing something similar to #7704 (that creates MCU target t hat this target can inherit from). As that one is blocked on another PR (should not, will update there if we can go ahead without that dependency) |
RTL8710 test results on GCC ARM 6 on PADI IoT Stamp, using Ameba RTL8195A dev board DAPLink interface. |
No, we can't get them to work. I know (barely) how to write GCC linker scripts, but not IAR or ARMCC. If someone does know some assistance would be appreciated. |
@DanielDmlee Can you run Mbed OS WiFi and Socket tests as instructed in https://github.com/ARMmbed/mbed-os/blob/940c4b891d66d6504f9f3fd86fefb05c1bf9a961/TESTS/netsocket/README.md So you need to enable full test set, and supply SSID and password. |
@SeppoTakalo Okay I'll check 'Mbed OS WiFi and Socket tests' |
I'm having trouble and need help. I have fetched this pull, as follows: then: resulting error:
When compiling for -m REALTEK_RTL8195AM, there no errors. Thank you |
@kissste |
The problem is that
So this inherits all values from RTL8195AM, among one is the claim to be Arduino Form factor. But this target is not. When device claims to be Arduino form factor, it should define all Arduino pinnames. Some drivers that are now pulled in the Mbed OS tree, uses those pinnames. To fix the issue @DanielDmlee should add following rule to this target:
|
@SeppoTakalo Thank you. Compiles now. Next steps - upload firmware it and see whether it works. |
@SeppoTakalo @kissste Thank you, I updated target.json again. |
Sorry to bug you again. Thank you |
4636b1a
to
f07d493
Compare
This will require rebase later. #7704 should go first (will contain driver update and MCU addition. this new target will inherit MCU definition, |
Sorry for the delay, due to the release period and some CI issues, it took a bit longer to progress with #8266. It was integrated, can you please rebase this to update ? This new target should inherit from realtek MCU_ target. |
Note that there was missing modified file at previous update, updated now. |
@DanielDmlee - Thanks for the PR. We are slowly migrating to IAR 8.x and ARMC6 and will like to know if the binaries in this PR are compatible to IAR 7.x and IAR 8.x? Also ARMC6 should not have compatibility issues but it will be good to test and confirm. |
@DanielDmlee What is the status for this PR? Based on the previous comments, all tests are passing and this is ready for review? |
@ashok-rao please review, we will as well soon |
@deepikabhavnani First of all, sorry for late replay. The GCC ARM linker script is correct. ARMCC and IAR are not correct so far. I need help to get them in. |
@0xc0170 Has been completed Greentea test (include netsock and network), but linker scripts for ARMCC and IAR are not correct so far. I need help to get them in. |
*mbed_boot*.o (+ZI) | ||
} | ||
|
||
ARM_LIB_STACK (0x10070000 - 0x1000) EMPTY 0x1000 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARM_LIB_STACK (0x10070000 - 0x1000) EMPTY 0x1000 { | |
ARM_LIB_STACK 0x10070000 EMPTY -0x1000 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the stack size for Mbed 5 is 0x400. 0x1000 is needed for Mbed 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deepikabhavnani Thank you for the review, I'll check your guide ASAP.
@@ -255,6 +255,7 @@ nsapi_error_t RTWInterface::disconnect() | |||
return NSAPI_ERROR_DEVICE_ERROR; | |||
} | |||
while(1) { | |||
wait(0.1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs own commit, explaining why is this wait needed here - a fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'm going to make own commit with explaining.
@@ -20,7 +20,9 @@ | |||
extern "C" { | |||
#endif | |||
|
|||
#if CONFIG_ADC_EN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also a fix, should not be part of "adding a new target commit"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'm going to make a new commit
@@ -0,0 +1,42 @@ | |||
/* mbed Microcontroller Library | |||
* Copyright (c) 2006-2013 ARM Limited | |||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new files should contain SPDX identifier (look at platform files for instance how to)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I understand. I'm going to update.
@@ -0,0 +1,229 @@ | |||
/* | |||
* Copyright (c) 2013-2016 Realtek Semiconductor Corp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
year 2018-2019 here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'm going to modify.
@DanielDmlee Any updates? |
Yes, I'm still finding solution fo ARMCC and IAR. |
Note, #9571 - might have implications for new targets. Please review (there's design document, and targets updated, if any questions, let us know). In any case, please reply to this comment if this change is already done or when completed. IAR8 used on master (8.32 to be specific), please consider this when updating IAR files in this PR. |
@DanielDmlee Are there any available updates on this PR? |
I'm trying fit to IAR8, ARM6, and 5.12 coming soon, so I'll update again after 5.12. |
@DanielDmlee as 5.12 has been out for a while now, any planned updates for this PR ? |
@adbridge This is the current suspended state. As you can see at #9808, 8195 which is the big brother of 8710 is not supported IAR8 version yet. So has been removed 'release_versions' field of RTL8195AM at 'target.json' file. In this situation, can I 8710 push to 5.11.5 if prepared ARM v5.06 and IAR7 compiler? |
Yes, please. |
@DanielDmlee Sorry 5.11.5 is no longer a supported version (and we do not accept PRs directly to patch release branches by default). |
@adbridge So does this mean that 8195 is from now on unsupported and should be removed even though it's supported by two compilers?! In my opinion 8710 should be treated the same as 8195. Same board package. |
8195 is not supported in Mbed starting 5.12 I believe (the release version 5 was removed from target description). As we extend our testing to cover more and more boards, we will be removing (or at least reclassifying) boards that fail testing or don't fulfil requirements like 3 compilers and are not fixed by the vendor in reasonable time. We hoped 8195 will be fixed by the vendor and we can reenable it in patch release, but that didn't happen yet. New boards won't be added if they don't pass testing on all 3 compilers. |
Hi Folks, I will close this commit. If the 8195 does not support all of the compilers in 5.12, the 8710 can not use as well. I'll be monitoring 8195 status and open commit again. |
Description
This pull request adds support for the Realtek RTL8710AF MCU. Port was done on the PADI IoT Stamp which sports this MCU. The target is relatively similar to the RTL8195AM except that no XIP is supported on the external flash.
Verified by running all test cases on the board, and by verifying that mbed-os-example-wifi works (same WiFi driver as the RTL8195AM is used).
Issues:
** For Greentea test,
Have to be separation RTL8195AM and RTL8710AF though DAPLink FW. Below comment is only temporarily can use for Greentea test.
Pull request type